Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep count of outstanding open spans #698

Closed
black-adder opened this issue Feb 15, 2018 · 3 comments
Closed

Keep count of outstanding open spans #698

black-adder opened this issue Feb 15, 2018 · 3 comments
Labels

Comments

@black-adder
Copy link
Contributor

black-adder commented Feb 15, 2018

We have numerous cases where users ask us why they can't see spans being persisted. One big cause is the user closes the tracer before the spans are persisted or they forget to finish the span.

If we keep a simple counter of number of started spans (and decrement per finish), then on tracer.close(), we can emit a log saying that: "N spans were started but not finished()".

Should be relatively easy to implement and will assist in debugging issues (unless no logger is configured...)

@yurishkuro
Copy link
Member

if we do that, it's not that far from actually preemptively flushing the spans that are potentially left unfinished. If we add a flag "in-progress" to the span, and change the merge function on the backend to recognize it, we could be able to support partial spans.

@de-robat
Copy link

de-robat commented Feb 26, 2018

for reference, supporting "partial spans" is an ongoing discussion at the jaeger-client over here jaegertracing/jaeger-client-java#231

@yurishkuro
Copy link
Member

Per #3362, we're sunsetting Jaeger clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants