This repository has been archived by the owner on May 23, 2024. It is now read-only.
Unfinished span counter and logging tests #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amim Knabben <amim.knabben@gmail.com>
Signed-off-by: Amim Knabben <amim.knabben@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 88.1% 88.12% +0.02%
==========================================
Files 59 59
Lines 3507 3513 +6
==========================================
+ Hits 3090 3096 +6
Misses 305 305
Partials 112 112
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR add a counter for unfinished/partial Span (showing a log.error for the user), so developers can be aware of these situations.
Related task. jaegertracing/jaeger#698
Short description of the changes
Add a new integer counter on Tracer, maybe makes sense to use the metrics already in the system instead.