Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span.Warnings not stored in Cassandra #705

Closed
vprithvi opened this issue Feb 20, 2018 · 3 comments · Fixed by #4313
Closed

Span.Warnings not stored in Cassandra #705

vprithvi opened this issue Feb 20, 2018 · 3 comments · Fixed by #4313
Labels
bug good first issue Good for beginners

Comments

@vprithvi
Copy link
Contributor

The model Span.Warnings field isn't stored in Cassandra.

Warnings []string `json:"warnings,omitempty"`

Cassandra schema for reference:

CREATE TABLE IF NOT EXISTS ${keyspace}.traces (
trace_id blob,
span_id bigint,
span_hash bigint,
parent_id bigint,
operation_name text,
flags int,
start_time bigint,
duration bigint,
tags list<frozen<keyvalue>>,
logs list<frozen<log>>,
refs list<frozen<span_ref>>,
process frozen<process>,
PRIMARY KEY (trace_id, span_id, span_hash)
)

The warnings field contains details on any conversion failures from thrift to the internal model object. I feel that this is important information that should be persisted along with the rest of the Span.

@vprithvi
Copy link
Contributor Author

vprithvi commented Dec 3, 2018

@ys Any opinions against doing this?

@yurishkuro
Copy link
Member

+1

@pts95
Copy link

pts95 commented Nov 17, 2019

I'm taking this issue up, if no one else is taking this. 🙏

yurishkuro pushed a commit that referenced this issue Mar 19, 2023
## Which problem is this PR solving?
- Resolves #705
- Resolves #704 

## Short description of the changes
- Instead of creating a separate column in the table, [we encode
warnings as tags, with a magic string
prefix](#4217 (comment))
so that they can be parsed and converted back to warnings during reads.

---------

Signed-off-by: Utsav Oza <utsavoza96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for beginners
Projects
None yet
4 participants