-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span.Warnings not stored in Cassandra #705
Labels
Comments
@ys Any opinions against doing this? |
+1 |
I'm taking this issue up, if no one else is taking this. 🙏 |
yurishkuro
pushed a commit
that referenced
this issue
Mar 19, 2023
## Which problem is this PR solving? - Resolves #705 - Resolves #704 ## Short description of the changes - Instead of creating a separate column in the table, [we encode warnings as tags, with a magic string prefix](#4217 (comment)) so that they can be parsed and converted back to warnings during reads. --------- Signed-off-by: Utsav Oza <utsavoza96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
model Span.Warnings
field isn't stored in Cassandra.jaeger/model/span.go
Line 59 in fcbd210
Cassandra schema for reference:
jaeger/plugin/storage/cassandra/schema/v001.cql.tmpl
Lines 54 to 68 in ec6378a
The warnings field contains details on any conversion failures from thrift to the internal model object. I feel that this is important information that should be persisted along with the rest of the Span.
The text was updated successfully, but these errors were encountered: