Use Golang built-in coverage test suites.

[ariefrahmansyah]

Which problem is this PR solving?

• Simplify test coverage scripts #797

Short description of the changes

• Simplify coverage step by using Golang built-in coverage test suites

[yurishkuro]

this is not equivalent, glide only returns top-level pkgs

$ glide novendor
./swagger-gen/...
./crossdock/...
./cmd/...
./plugin/...
./storage/...
./thrift-gen/...
./examples/...
./model/...
./pkg/...
.

[ariefrahmansyah]

Well, they are returning different result. But once they go to go test $TOP_PKGS, the test results are same.
There are two options I have in mind:

1. Keep using glide novendor
2. Rename TOP_PKGS to TEST_PKGS

[yurishkuro]

I certainly want to stop using glide for that, I'm just concerned that there are 8 occurrences of TOP_PKGS in the Makefile, so we need to ensure that changing what it refers to is still equivalent for all other built steps using it.

[ariefrahmansyah]

Got it. I understand your concern.

TOP_PKGS is used by 4 Go tools: go list, go test, go vet, and golint. And 2 other tools: gosec and gosimple. All of Go tools have the same behavior on handling packages argument. I also read gosec and gosimple documentation and the way they handle packages argument is same as Go tools.

Reading documentation is not enough, so I created a simple script to compare them. Please check it here: https://gist.github.com/ariefrahmansyah/89cecbd7f933f80a9258c0028c92a2f3

I'm sure that migrating from glide novendor to go list is fine 🙂

By the way, another thing to discuss, maybe we can merge TOP_PKGS to ALL_PKGS 🤔

[yurishkuro]

By the way, another thing to discuss, maybe we can merge TOP_PKGS to ALL_PKGS

yes, I think it would make sense, I never liked the split, it was only there because some tools worked differently.

[yurishkuro]

@ariefrahmansyah do you want to try again?

My main concern is how to deal with packages where we explicitly have .nocover marker

$ find . -name .nocover
./cmd/flags/.nocover
./cmd/agent/app/httpserver/thrift-0.9.2/.nocover
./cmd/agent/.nocover
./pkg/version/.nocover
./pkg/kafka/producer/.nocover
./pkg/cassandra/config/.nocover
./pkg/cassandra/gocql/testutils/.nocover
./pkg/cassandra/gocql/.nocover
./pkg/es/config/.nocover
./pkg/es/.nocover

[ariefrahmansyah]

@yurishkuro hi, yes i will find a time this week to try this again. thanks