Fix tools pruned by dep

[isaachier]

Signed-off-by: Isaac Hier isaachier@gmail.com

Which problem is this PR solving?

• Resolves dep upgrade broke proto-install #1258.

Short description of the changes

• Use required list to maintain tool dependencies.

[codecov]

Codecov Report

Merging #1260 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1260   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         160     160           
  Lines        7181    7181           
======================================
  Hits         7181    7181

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc87c85...577ffad. Read the comment docs.

[isaachier]

I think the install is fixed, but at least for me, make proto is broken.

[olivierboucher]

@isaachier Please look at the changes I made in #1214 . I managed to have make proto working.

[isaachier]

Cool @olivierboucher will do thanks.

[isaachier]

Actually, the only problem I had was because I was using protoc-3.0.0 when should have been using protoc >= 3.5.1. Works fine now.

[yurishkuro]

Actually, the only problem I had was because I was using protoc-3.0.0 when should have been using protoc >= 3.5.1. Works fine now.

what were the issues with older protoc?

Unfortunately, afaik protoc does not have a version command so that we could check it during the build.

[yurishkuro]

Thanks, Isaac!

[yurishkuro]

I'll merge it on green build, but we should figure out how to pin to versions instead of raw commit hash. E.g. gogo/googleapis has a 1.1.0 release in August, which is later than the commit we have. And gogo/protobuf has pretty frequent releases.

[yurishkuro]

#1262

[isaachier]

It should work with newer versions too. This is copied from the old glide.yaml.

[isaachier]

Glad to help! I saw the issue when I checked the gogo/protobuf repo and saw the install-protoc.sh script. It specifically downloads 3.5.1. The Ubuntu package I was using was pretty old in comparison.