let cassandra servers contain whitespace in config #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlpokus
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
======================================
Coverage 100% 100%
======================================
Files 162 162
Lines 7259 7261 +2
======================================
+ Hits 7259 7261 +2
Continue to review full report at Codecov.
|
Signed-off-by: Karl Pokus <karl.pokus@gmail.com>
karlpokus
force-pushed
the
strip-whitespace-from-cassandra-hosts
branch
from
b5eb850
to
bfa7b78
Compare
|
Didn't know about DCO. Sorry. Commit amended. |
black-adder
approved these changes
Jan 28, 2019
|
Cheers! |
|
@karlpokus how do you feel about sending your second PR to this project? #1302 seems easy now that you did this one, doesn't it ;-) |
|
@jpkrohling Sure. I'll take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes