Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsorted imports #1347

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Fix unsorted imports #1347

merged 2 commits into from
Feb 18, 2019

Conversation

huynguyennovem
Copy link

Which problem is this PR solving?

  • Imports should be sorted by Go coding convention

Short description of the changes

  • Sort the imports

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #1347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1347   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         162     162           
  Lines        7364    7364           
======================================
  Hits         7364    7364

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6d999...d772347. Read the comment docs.

@pavolloffay
Copy link
Member

pavolloffay commented Feb 14, 2019

@huynq0911 DCO failed. Please recmmit with g commit -m "foo" -s -s flag

@huynguyennovem
Copy link
Author

huynguyennovem commented Feb 15, 2019

@huynq0911 DCO failed. Please recmmit with g commit -m "foo" -s -s flag

@pavolloffay, I have re-committed, please help me to check it again!

@huynguyennovem
Copy link
Author

@pavolloffay: After resolving conflict, I saw some Unknow field and Unresolved reference error in line 107 and line 232-235. Seem the error occurred from the @black-adder PR (Remove SASI indices). Please help me to clarify it!

@pavolloffay
Copy link
Member

@huynq0911 I had to merge a PR which caused conflict here.

I am not sure why build is not failing due to incorrect order in master - might be better to look at that. Also please do not fix the order in auto-generated files.

@huynguyennovem
Copy link
Author

@huynq0911 I had to merge a PR which caused conflict here.

I am not sure why build is not failing due to incorrect order in master - might be better to look at that. Also please do not fix the order in auto-generated files.

Okay, I will fix that right now!

Imports should be sorted by Golang coding convention

Signed-off-by: Nguyen Quang Huy <huynq0911@gmail.com>
@yurishkuro yurishkuro merged commit f9a0ea3 into jaegertracing:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants