-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsorted imports #1347
Fix unsorted imports #1347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
======================================
Coverage 100% 100%
======================================
Files 162 162
Lines 7364 7364
======================================
Hits 7364 7364 Continue to review full report at Codecov.
|
@huynq0911 DCO failed. Please recmmit with |
@pavolloffay, I have re-committed, please help me to check it again! |
@pavolloffay: After resolving conflict, I saw some |
@huynq0911 I had to merge a PR which caused conflict here. I am not sure why build is not failing due to incorrect order in master - might be better to look at that. Also please do not fix the order in auto-generated files. |
Okay, I will fix that right now! |
Imports should be sorted by Golang coding convention Signed-off-by: Nguyen Quang Huy <huynq0911@gmail.com>
Which problem is this PR solving?
Short description of the changes