Discover dependencies table version automatically #1364
Conversation
Signed-off-by: Won Jun Jang <wjang@uber.com>
black-adder
requested review from
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
| // GetDependencyVersion attempts to determine the version of the dependencies table. | ||
| // TODO: Remove this once we've migrated to V2 permanently. | ||
| func GetDependencyVersion(s cassandra.Session) Version { | ||
| if err := s.Query("SELECT ts from dependencies_v2 limit 1;").Exec(); err != nil { |
There was a problem hiding this comment.
what kind of error is returned? just curious
There was a problem hiding this comment.
InvalidRequest: Error from server: code=2200 [Invalid query] message="unconfigured table dependencies"
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
======================================
Coverage 100% 100%
======================================
Files 163 164 +1
Lines 7374 7376 +2
======================================
+ Hits 7374 7376 +2
Continue to review full report at Codecov.
|
Signed-off-by: Won Jun Jang <wjang@uber.com>
|
@black-adder I have raised this also because of jaegertracing/spark-dependencies#58. There can be other components which expect schema for v1 dependencies. We have failing CI jobs now in opearator bc dep. job tries to write to old dependnecies table. in spark job we should do the same - automatically detect the table |
| ) | ||
|
|
||
| // GetDependencyVersion attempts to determine the version of the dependencies table. | ||
| // TODO: Remove this once we've migrated to V2 permanently. |
Signed-off-by: Won Jun Jang <wjang@uber.com>
|
@black-adder can this be merged? |
Signed-off-by: Won Jun Jang wjang@uber.com
Resolves #1363
EnableDependenciesV2flag