Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for tags + duration in query parser #1477

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Apr 17, 2019

The check only applies to Cassandra backend, which already has the same check enabled.

Resolves #1047.

Signed-off-by: Ivan Babrou ibobrik@gmail.com

@bobrik
Copy link
Contributor Author

bobrik commented Apr 17, 2019

Some builds need a restart:

# cd .; git clone https://go.googlesource.com/tools /home/travis/gopath/src/golang.org/x/tools
Cloning into '/home/travis/gopath/src/golang.org/x/tools'...
error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502 Bad Gateway
fatal: The remote end hung up unexpectedly
package golang.org/x/tools/cover: exit status 128
make: *** [install-tools] Error 1

@yurishkuro
Copy link
Member

Unit test is failing

The check only applies to Cassandra backend,
which already has the same check enabled.

Resolves jaegertracing#1047.

Signed-off-by: Ivan Babrou <ibobrik@gmail.com>
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cb226ff). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1477   +/-   ##
=========================================
  Coverage          ?   99.83%           
=========================================
  Files             ?      179           
  Lines             ?     8557           
  Branches          ?        0           
=========================================
  Hits              ?     8543           
  Misses            ?        7           
  Partials          ?        7
Impacted Files Coverage Δ
cmd/query/app/query_parser.go 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb226ff...5605d1e. Read the comment docs.

@bobrik
Copy link
Contributor Author

bobrik commented Apr 18, 2019

@yurishkuro all green now.

@yurishkuro yurishkuro merged commit 7009c98 into jaegertracing:master Apr 19, 2019
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary restriction on tags + min-duration queries
2 participants