Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ES dependency from crossdock #1514

Merged

Conversation

yurishkuro
Copy link
Member

In #1461 the crossdock step fail repeatedly when trying to build an image with elasticcurator

https://travis-ci.org/jaegertracing/jaeger/jobs/527861990#L620

Elastic is not needed for crossdock.

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #1514 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
- Coverage   99.79%   99.77%   -0.03%     
==========================================
  Files         182      182              
  Lines        8738     8738              
==========================================
- Hits         8720     8718       -2     
- Misses          9       11       +2     
  Partials        9        9
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 99.21% <0%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fff102...5086a77. Read the comment docs.

@yurishkuro yurishkuro merged commit 8634ee7 into jaegertracing:master May 5, 2019
@yurishkuro yurishkuro deleted the remove-es-from-crossdock branch May 5, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant