Fix flaky ES span reader test due to date differences #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 197 197
Lines 9627 9627
=======================================
Hits 9477 9477
Misses 114 114
Partials 36 36Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Oct 9, 2019
|
Thanks Pavol |
radekg
pushed a commit
to Klarrio/jaeger
that referenced
this pull request
Oct 28, 2019
…1847) * Fix flaky ES span reader test due to date differences Signed-off-by: Pavol Loffay <ploffay@redhat.com> * fmt Signed-off-by: Pavol Loffay <ploffay@redhat.com> Signed-off-by: radekg <radek@gruchalski.com>
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
…1847) * Fix flaky ES span reader test due to date differences Signed-off-by: Pavol Loffay <ploffay@redhat.com> * fmt Signed-off-by: Pavol Loffay <ploffay@redhat.com> Signed-off-by: Jonah Back <jonah@jonahback.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1713