-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cassandra] Blacklisting/Whitelisting Tags for Indexing #1904
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Manually confirmed in our environment that blacklisted tags are not being indexed and other tags are. Removing draft. |
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
+ Coverage 98.42% 98.45% +0.03%
==========================================
Files 197 198 +1
Lines 9648 9706 +58
==========================================
+ Hits 9496 9556 +60
+ Misses 116 114 -2
Partials 36 36
Continue to review full report at Codecov.
|
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
e49d451
to
9726f1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, only a few small comments
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_blacklist.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_whitelist.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_blacklist.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should not have jaeger-ui submodule change in this PR. Please make sure the submodule points to the same revision as master
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match_test.go
Outdated
Show resolved
Hide resolved
Please make sure the description says |
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Which problem is this PR solving?
Short description of the changes
tag-index-blacklist
,tag-index-whitelist