Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger agent logs "0" whenever sampling strategies are requested #2382

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Jaeger agent logs "0" whenever sampling strategies are requested #2382

merged 1 commit into from
Aug 11, 2020

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

Short description of the changes

  • Removed extraneous fmt.Println from sampling_from_domain

Fixes #2356

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested a review from a team as a code owner August 11, 2020 09:00
@jpkrohling
Copy link
Contributor Author

@agaudreault-jive, would you be able to try this out?

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #2382 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
- Coverage   95.62%   95.61%   -0.01%     
==========================================
  Files         206      206              
  Lines       10548    10547       -1     
==========================================
- Hits        10086    10084       -2     
  Misses        395      395              
- Partials       67       68       +1     
Impacted Files Coverage Δ
...el/converter/thrift/jaeger/sampling_from_domain.go 100.00% <ø> (ø)
cmd/query/app/server.go 90.90% <0.00%> (-2.28%) ⬇️
plugin/storage/integration/integration.go 80.86% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4343528...5e46048. Read the comment docs.

@jpkrohling jpkrohling merged commit 6e04d9d into jaegertracing:master Aug 11, 2020
@agaudreault
Copy link

@agaudreault-jive, would you be able to try this out?

That was the one! 🎉 Thanks for finding it out.

@jpkrohling jpkrohling deleted the jpkrohling/issue2356 branch July 28, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger agent logs "0" whenever sampling strategies are requested
3 participants