Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in collector when Zipkin server is shutdown #2392

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

Sreevani871
Copy link
Contributor

@Sreevani871 Sreevani871 commented Aug 14, 2020

…cit shutdown

Signed-off-by: Sreevani871 sreevani@freshdesk.com

Which problem is this PR solving?

Short description of the changes

  • Handling explicit shutdown case to avoid collector exiting abruptly after Zipkin server close to allow shutdown process to complete.

…cit shutdown

Signed-off-by: Sreevani871 <sreevani@freshdesk.com>
@Sreevani871 Sreevani871 requested a review from a team as a code owner August 14, 2020 05:22
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #2392 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +0.01%     
==========================================
  Files         206      206              
  Lines       10547    10549       +2     
==========================================
+ Hits        10084    10088       +4     
+ Misses        395      394       -1     
+ Partials       68       67       -1     
Impacted Files Coverage Δ
cmd/collector/app/server/zipkin.go 0.00% <0.00%> (ø)
cmd/collector/app/collector.go 69.56% <100.00%> (+0.44%) ⬆️
plugin/storage/integration/integration.go 80.38% <0.00%> (-0.48%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.79%) ⬆️
cmd/query/app/static_handler.go 85.83% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5daae75...9f97e2d. Read the comment docs.

@yurishkuro yurishkuro changed the title Fix exiting collector abruptly after Zipkin sever close in case of shutdown Fix panic in collector when Zipkin sever is shutdown Aug 14, 2020
@yurishkuro yurishkuro changed the title Fix panic in collector when Zipkin sever is shutdown Fix panic in collector when Zipkin server is shutdown Aug 14, 2020
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants