Fix misleading use-alias help doc #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <albert.teoh@logz.io>
Codecov Report
@@ Coverage Diff @@
## master #2692 +/- ##
==========================================
+ Coverage 95.57% 95.58% +0.01%
==========================================
Files 215 215
Lines 9579 9579
==========================================
+ Hits 9155 9156 +1
+ Misses 346 345 -1
Partials 78 78
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Dec 15, 2020
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Jan 25, 2021
Signed-off-by: albertteoh <albert.teoh@logz.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: albertteoh albert.teoh@logz.io
Which problem is this PR solving?
Short description of the changes
es.max-span-ageis not taken into account whenuse-aliasis enabled, which causes users to think that all indices under thejaeger-...-readalias are searchable. However,es.max-span-ageis used to define the starting window of ES queries like in this example.es.max-span-agedoes influence search window start times, without being too specific to implementation.