Remove deprecated admin server flags #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jaegertracing#2738 Signed-off-by: pradeepnnv <pradeepnnv@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2752 +/- ##
==========================================
+ Coverage 95.82% 95.86% +0.03%
==========================================
Files 217 217
Lines 9656 9649 -7
==========================================
- Hits 9253 9250 -3
+ Misses 332 330 -2
+ Partials 71 69 -2
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 31, 2021
cmd/flags/admin.go
Outdated
| @@ -36,8 +36,7 @@ const ( | |||
| adminHTTPPort = "admin-http-port" | |||
| adminHTTPHostPort = "admin.http.host-port" | |||
|
|
|||
| healthCheckHTTPPortWarning = "(deprecated, will be removed after 2020-03-15 or in release v1.19.0, whichever is later)" | |||
| adminHTTPPortWarning = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)" | |||
| adminHTTPPortWarning = "(deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)" | |||
There was a problem hiding this comment.
please remove both deprecated flags since we're changing this module
There was a problem hiding this comment.
Removed adminHTTPPortWarning as well. Please review.
Add breaking change entry to CHANGELOG Fixes part of jaegertracing#2738 Signed-off-by: pradeepnnv <pradeepnnv@gmail.com>
yurishkuro
reviewed
Feb 1, 2021
Update Change log to use actual CLI Flags instead of variable names. Fixes part of jaegertracing#2738 Signed-off-by: pradeepnnv <pradeepnnv@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: pradeepnnv <pradeepnnv@gmail.com>
pradeepnnv
force-pushed
the
remove_healthCheckHTTPPortWarning
branch
from
1b46aaf
to
7b1469f
Compare
yurishkuro
approved these changes
Feb 1, 2021
yurishkuro
changed the title
|
@pradeepnnv Thank you! |
|
Thanks @yurishkuro for your help and guidance. Hope i'll be able to contribute more for Jaeger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2738
Signed-off-by: pradeepnnv pradeepnnv@gmail.com