Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test timeout for TestKafkaStorage #2873

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Increase test timeout for TestKafkaStorage #2873

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4bde81
Increasing test timeout to allow for trace storage settle
LostLaser Mar 10, 2021
f6a4d15
Merge branch 'master' of https://github.com/jaegertracing/jaeger into…
LostLaser Mar 11, 2021
9e81d8e
Updating max storage test wait time to 10 seconds
LostLaser Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/storage/integration/integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
)

const (
iterations = 30
iterations = 40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go to 100

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked writes didn't seem to help unfortunately. I attempted to switch the acks to "local" as well as "all" to no avail. I'm guessing the ack never actually comes into effect because there is probably a timeout on the message transfer that is greater than the test time we have set. I ran kafkacat to see if the spans ever made it to the cluster and it seemed like the messages would always make it after some time.

)

// StorageIntegration holds components for storage integration test
Expand Down Expand Up @@ -90,7 +90,7 @@ func (s *StorageIntegration) waitForCondition(t *testing.T, predicate func(t *te
if predicate(t) {
return true
}
time.Sleep(100 * time.Millisecond) // Will wait up to 3 seconds at worst.
time.Sleep(100 * time.Millisecond) // Will wait up to 4 seconds at worst.
}
return predicate(t)
}
Expand Down