Changed Range Query to use startTimeMillis date field instead of startTime field #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cit shutdown Signed-off-by: Sreevani871 <sreevani@freshdesk.com>
…alises:true Signed-off-by: Sreevani871 <sreevani.karasala@freshworks.com>
Signed-off-by: Sreevani871 <sreevani.karasala@freshworks.com>
Signed-off-by: Sreevani871 <sreevani.karasala@freshworks.com>
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 223 223
Lines 9720 9726 +6
=======================================
+ Hits 9327 9333 +6
Misses 325 325
Partials 68 68
Continue to review full report at Codecov.
|
albertteoh
reviewed
May 10, 2021
Comment on lines
371
to
381
| traceQuery := buildTraceByIDQuery(traceID) | ||
| var query *elastic.BoolQuery | ||
| if s.useReadWriteAliases { | ||
| query = elastic.NewBoolQuery(). | ||
| Must(startTimeRangeQuery). | ||
| Must(traceQuery) | ||
| } else { | ||
| query = elastic.NewBoolQuery(). | ||
| Must(traceQuery) | ||
| } | ||
|
|
There was a problem hiding this comment.
We can simplify to:
query := elastic.NewBoolQuery().
Must(traceQuery)
if s.useReadWriteAliases {
startTimeRangeQuery := s.buildStartTimeQuery(startTime.Add(-time.Hour*24), endTime.Add(time.Hour*24))
query = query.Must(startTimeRangeQuery)
}
There was a problem hiding this comment.
Yes. Changed suggested way.
Signed-off-by: Sreevani871 <sreevani.karasala@freshworks.com>
albertteoh
previously approved these changes
May 11, 2021
albertteoh
approved these changes
May 11, 2021
|
Thanks @Sreevani871 ! |
|
This actually brought our average search time on Jaeger UI by 1/10. For search all the traces for a particular service/operation in last 2 hours - it used to take 30 secs on average [ We use ES backend and aliases ]. It is down to 3 seconds now. Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
startTimeMillisfor findTraces API , when es-aliases are used #2923Short description of the changes
If
es.use-aliasescofiguration field is set to true, jaeger-span-read alias is used in Elasticsearch which is applying to all indexes. Using time range query Elasticsearch will skip the unnecessary shards while searching. At present in the code, thestartTimefield is used in range query but it is stored astype: longin Elasticsearch mapping. it's not skipping the unnecessary shards since Elasticsearch timeRange queries works with onlytype: datefield as discussed in the issue: #2923.Using startTimeMillisField irrespective of
es.use-aliases: truewill improve the performance of the ES query.Closed PR: #2978