-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenTelemetry SDK in HotROD #3390
Use OpenTelemetry SDK in HotROD #3390
Conversation
* replacing the jaeger-client-go ot tracer implementation with the ot-otel bridge implementation Signed-off-by: rbroggi <ro_broggi@hotmail.com>
* replacing the jaeger-client-go ot tracer implementation with the ot-otel bridge implementation Signed-off-by: rbroggi <ro_broggi@hotmail.com>
Codecov ReportBase: 96.51% // Head: 96.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
- Coverage 96.51% 96.48% -0.03%
==========================================
Files 260 260
Lines 15215 15215
==========================================
- Hits 14684 14680 -4
- Misses 449 452 +3
- Partials 82 83 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jaeger-ui submodule update should not be in this PR, please make sure to rebase off master
* restoring jaeger-ui changes Signed-off-by: rbroggi <ro_broggi@hotmail.com>
Some comments: With this change something is not really going as planned as the DAG I get is: instead of the one in the article Another change that will have to be documented is that we also need to open the grpc port while running the all-in-one container for the go binary to reach jaeger: docker run -d -p6831:6831/udp -p16686:16686 -p14268:14268 jaegertracing/all-in-one:latest Will there be a way to update the medium article (it was very useful to me, it would be a shame to loose it) |
Dear @yurishkuro, would you have any advice on how I could troubleshoot this problem efficiently? By investigating the code I fail to understand why this change had an impact only in the |
I suspect this has something to do with the propagator of the context on the wire. What happens when the code calls tracer.Inject() and the tracer is the one from the bridge? |
ee92441
to
17df91f
Compare
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: rbroggi <ro_broggi@hotmail.com>
…rtracing#3394) Bumps [go.opentelemetry.io/collector/model](https://github.com/open-telemetry/opentelemetry-collector) from 0.38.0 to 0.39.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-collector@v0.38.0...v0.39.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/collector/model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ertracing#3400) * Go back to golang:1.17-alpine Signed-off-by: Yuri Shkuro <github@ysh.us> * Add build-base to Docker image Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Hu Shuai <hus.fnst@fujitsu.com>
* no need to globally register the otel tracer Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: rbroggi <ro_broggi@hotmail.com>
* jaeger-ui update Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: rbroggi <ro_broggi@hotmail.com>
Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: rbroggi <ro_broggi@hotmail.com>
17df91f
to
d8f4543
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
This pull request has been automatically closed due to inactivity. You may re-open it if you need more time. We really appreciate your contribution and we are sorry that this has not been completed. |
Based on earlier PR #3390 by @rbroggi. ## Which problem is this PR solving? - Resolves #3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in #3766) --------- Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: rbroggi <ro_broggi@hotmail.com>
This was finished in #4187 |
Based on earlier PR jaegertracing#3390 by @rbroggi. ## Which problem is this PR solving? - Resolves jaegertracing#3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in jaegertracing#3766) --------- Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: rbroggi <ro_broggi@hotmail.com>
Based on earlier PR jaegertracing#3390 by @rbroggi. ## Which problem is this PR solving? - Resolves jaegertracing#3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in jaegertracing#3766) --------- Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Signed-off-by: rbroggi ro_broggi@hotmail.com
Which problem is this PR solving?
Short description of the changes