-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split opensearch tests from elasticsearch #3423
Split opensearch tests from elasticsearch #3423
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## main #3423 +/- ##
=======================================
Coverage 96.48% 96.49%
=======================================
Files 261 261
Lines 15267 15267
=======================================
+ Hits 14731 14732 +1
+ Misses 453 452 -1
Partials 83 83
Continue to review full report at Codecov.
|
@jpkrohling what kind of instability are you seeing? Also which version of OpenSearch are we testing against? |
The tests are failing intermittently. I've seen it during the release and during my latest PRs. We seem to be using 1.0.0. |
matrix: | ||
version: | ||
- major: 1.x | ||
image: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should bump this
@yurishkuro current is 1.2.0 I can submit PR if you want. |
The integration tests don't seem to be as stable on opensearch as they are for elasticsearch, and restarting it would restart the entire matrix. This PR splits the opensearch test execution from those of elasticsearch, making it easier to re-run only that portion of the matrix. It would also help us determine whether opensearch is the only stable variant for this integration test.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de