Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split opensearch tests from elasticsearch #3423

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Split opensearch tests from elasticsearch #3423

merged 1 commit into from
Dec 2, 2021

Conversation

jpkrohling
Copy link
Contributor

The integration tests don't seem to be as stable on opensearch as they are for elasticsearch, and restarting it would restart the entire matrix. This PR splits the opensearch test execution from those of elasticsearch, making it easier to re-run only that portion of the matrix. It would also help us determine whether opensearch is the only stable variant for this integration test.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested a review from a team as a code owner December 2, 2021 13:32
@jpkrohling jpkrohling requested a review from yurishkuro December 2, 2021 13:32
@yurishkuro yurishkuro enabled auto-merge (squash) December 2, 2021 13:38
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #3423 (a173035) into main (5015a36) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3423   +/-   ##
=======================================
  Coverage   96.48%   96.49%           
=======================================
  Files         261      261           
  Lines       15267    15267           
=======================================
+ Hits        14731    14732    +1     
+ Misses        453      452    -1     
  Partials       83       83           
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.20%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.21% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5015a36...a173035. Read the comment docs.

@yurishkuro yurishkuro merged commit 62cc3da into jaegertracing:main Dec 2, 2021
@jkowall
Copy link
Contributor

jkowall commented Dec 2, 2021

The integration tests don't seem to be as stable on opensearch as they are for elasticsearch, and restarting it would restart the entire matrix. This PR splits the opensearch test execution from those of elasticsearch, making it easier to re-run only that portion of the matrix. It would also help us determine whether opensearch is the only stable variant for this integration test.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling what kind of instability are you seeing? Also which version of OpenSearch are we testing against?

@jpkrohling
Copy link
Contributor Author

The tests are failing intermittently. I've seen it during the release and during my latest PRs. We seem to be using 1.0.0.

matrix:
version:
- major: 1.x
image: 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump this

@jkowall
Copy link
Contributor

jkowall commented Dec 7, 2021

@yurishkuro current is 1.2.0 I can submit PR if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants