-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy metrics API from jaeger-lib #3767
Merged
yurishkuro
merged 10 commits into
jaegertracing:main
from
yurishkuro:redefine-metrics-api
Jun 21, 2022
Merged
Copy metrics API from jaeger-lib #3767
yurishkuro
merged 10 commits into
jaegertracing:main
from
yurishkuro:redefine-metrics-api
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov Report
@@ Coverage Diff @@
## main #3767 +/- ##
==========================================
+ Coverage 97.49% 97.54% +0.05%
==========================================
Files 271 282 +11
Lines 16004 16426 +422
==========================================
+ Hits 15603 16023 +420
- Misses 317 319 +2
Partials 84 84
Continue to review full report at Codecov.
|
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
* Copy metrics API from jaeger-lib Signed-off-by: Yuri Shkuro <github@ysh.us> * fix builder Signed-off-by: Yuri Shkuro <github@ysh.us> * move Signed-off-by: Yuri Shkuro <github@ysh.us> * copy-fork Signed-off-by: Yuri Shkuro <github@ysh.us> * upgrade-agent Signed-off-by: Yuri Shkuro <github@ysh.us> * refactor-all Signed-off-by: Yuri Shkuro <github@ysh.us> * fmt Signed-off-by: Yuri Shkuro <github@ysh.us> * undo Signed-off-by: Yuri Shkuro <github@ysh.us> * fix Signed-off-by: Yuri Shkuro <github@ysh.us> * tests Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial round of refactoring. Contains one hack in the form of JLibAdapter needed to keep the factory compatible with the
jaeger-client-go
. In the follow-up PR we can flip that: copy prom/expvar implementations internally to remove dependency on jaeger-lib from the main code, and keep an adapter to initializejaeger-client-go
.Partially addresses #3766