Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy metrics API from jaeger-lib #3767

Merged
merged 10 commits into from
Jun 21, 2022

Conversation

yurishkuro
Copy link
Member

Initial round of refactoring. Contains one hack in the form of JLibAdapter needed to keep the factory compatible with the jaeger-client-go. In the follow-up PR we can flip that: copy prom/expvar implementations internally to remove dependency on jaeger-lib from the main code, and keep an adapter to initialize jaeger-client-go.

Partially addresses #3766

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 21, 2022 03:24
@yurishkuro yurishkuro requested a review from vprithvi June 21, 2022 03:24
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #3767 (4eb9546) into main (dfcded2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3767      +/-   ##
==========================================
+ Coverage   97.49%   97.54%   +0.05%     
==========================================
  Files         271      282      +11     
  Lines       16004    16426     +422     
==========================================
+ Hits        15603    16023     +420     
- Misses        317      319       +2     
  Partials       84       84              
Impacted Files Coverage Δ
cmd/agent/app/builder.go 96.07% <ø> (ø)
cmd/agent/app/configmanager/metrics.go 100.00% <ø> (ø)
cmd/agent/app/httpserver/srv.go 100.00% <ø> (ø)
cmd/agent/app/processors/thrift_processor.go 100.00% <ø> (ø)
cmd/agent/app/reporter/client_metrics.go 100.00% <ø> (ø)
cmd/agent/app/reporter/connect_metrics.go 100.00% <ø> (ø)
cmd/agent/app/reporter/grpc/builder.go 95.16% <ø> (ø)
cmd/agent/app/reporter/grpc/collector_proxy.go 100.00% <ø> (ø)
cmd/agent/app/reporter/metrics.go 100.00% <ø> (ø)
cmd/agent/app/servers/tbuffered_server.go 94.33% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcded2...4eb9546. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 3d67ac8 into jaegertracing:main Jun 21, 2022
@yurishkuro yurishkuro deleted the redefine-metrics-api branch June 21, 2022 15:59
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
* Copy metrics API from jaeger-lib

Signed-off-by: Yuri Shkuro <github@ysh.us>

* fix builder

Signed-off-by: Yuri Shkuro <github@ysh.us>

* move

Signed-off-by: Yuri Shkuro <github@ysh.us>

* copy-fork

Signed-off-by: Yuri Shkuro <github@ysh.us>

* upgrade-agent

Signed-off-by: Yuri Shkuro <github@ysh.us>

* refactor-all

Signed-off-by: Yuri Shkuro <github@ysh.us>

* fmt

Signed-off-by: Yuri Shkuro <github@ysh.us>

* undo

Signed-off-by: Yuri Shkuro <github@ysh.us>

* fix

Signed-off-by: Yuri Shkuro <github@ysh.us>

* tests

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant