Bump go-kit to 0.12.0 #3774
Closed
Bump go-kit to 0.12.0 #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through the dependency on go-kit/k...@v0.11.0, jaegertracing/jaeger depends on github.com/dgrijalva/jwt-go. There are a slew of vulns against that repo and it is abandoned in favour of https://github.com/golang-jwt/jwt . go-kit 0.12.0 upgrades to the new repo, so this commit bumps go kit to 0.12.0 to mitigate this Signed-off-by: sinkingpoint <colin@quirl.co.nz>
sinkingpoint
force-pushed
the
sinkingpoint/go-kit-bump
branch
from
72b7dbe
to
609acd9
Compare
|
this is already done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the dependency on go-kit/k...@v0.11.0, jaegertracing/jaeger
depends on github.com/dgrijalva/jwt-go. There are a slew of vulns
against that repo (e.g. dgrijalva/jwt-go#428)
and it is abandoned in favour of https://github.com/golang-jwt/jwt .
go-kit 0.12.0 upgrades to the new repo, so this commit bumps go kit to
0.12.0 to mitigate this
Which problem is this PR solving?
Short description of the changes