Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi arch support to cassandra-schema container #4122

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

jkandasa
Copy link
Member

Which problem is this PR solving?

  • jager-cassandra-schema container does not have multi arch support.
  • This PR adds support to generate multi arch container images

Short description of the changes

  • additionally passed platform arguments to the build script

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
@jkandasa jkandasa requested a review from a team as a code owner December 22, 2022 10:37
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 97.17% // Head: 97.17% // No change to project coverage 👍

Coverage data is based on head (954006c) compared to base (503426c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4122   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files         295      295           
  Lines       17413    17413           
=======================================
  Hits        16921    16921           
  Misses        396      396           
  Partials       96       96           
Flag Coverage Δ
unittests 97.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro
Copy link
Member

Please describe how this was tested

@jkandasa
Copy link
Member Author

@yurishkuro I have not tested this locally. But I see a test runs this change
https://github.com/jaegertracing/jaeger/actions/runs/3757030553/jobs/6383776865#step:11:2249
I am not sure about the final image verified or not.

@yurishkuro yurishkuro merged commit 5f7865a into jaegertracing:main Dec 22, 2022
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Feb 22, 2023
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
)

Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
)

Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants