Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test - TestSpanProcessorWithOnDroppedSpanOption #4489

Merged
merged 1 commit into from
May 27, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented May 27, 2023

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner May 27, 2023 23:13
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (015020d) 97.05% compared to head (44e5db3) 97.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4489      +/-   ##
==========================================
+ Coverage   97.05%   97.06%   +0.01%     
==========================================
  Files         300      300              
  Lines       17740    17813      +73     
==========================================
+ Hits        17217    17290      +73     
  Misses        419      419              
  Partials      104      104              
Flag Coverage Δ
unittests 97.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/agent/app/reporter/grpc/reporter.go 100.00% <ø> (ø)
cmd/query/app/query_parser.go 100.00% <ø> (ø)
...in/sampling/strategystore/static/strategy_store.go 97.26% <ø> (ø)
plugin/metrics/prometheus/factory.go 100.00% <100.00%> (ø)
...trics/prometheus/metricsstore/dbmodel/to_domain.go 100.00% <100.00%> (ø)
plugin/metrics/prometheus/metricsstore/reader.go 100.00% <100.00%> (ø)
plugin/metrics/prometheus/options.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 756bc4e into jaegertracing:main May 27, 2023
@yurishkuro yurishkuro deleted the fix-4450 branch May 27, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Flaky Test: TestSpanProcessorWithOnDroppedSpanOption
1 participant