Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding HTTP compression #545

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Adding HTTP compression #545

merged 2 commits into from
Nov 17, 2017

Conversation

ledor473
Copy link
Member

All endpoint now supports HTTP compression.

This fix #542.

Now:
main.css --> 103 KB
main.js --> 522 KB

@black-adder
Copy link
Contributor

lgtm, run make fmt and then commit and push again

Adding HTTP compression
ce9f725 
Signed-off-by: Louis-Etienne Dorval <louis-etienne.dorval@ticketmaster.com>
@ledor473
Copy link
Member Author

ledor473 commented Nov 17, 2017 •
edited
Loading

@black-adder forgot that one.. The newest commit package both the fmt and the code update

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.955% when pulling ce9f725 on Ticketmaster:http-compression into acfbf29 on jaegertracing:master.

@ghost ghost assigned black-adder Nov 17, 2017
@ghost ghost added the review label Nov 17, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 100.0% when pulling f157f97 on Ticketmaster:http-compression into acfbf29 on jaegertracing:master.

@black-adder black-adder merged commit 6bf382a into jaegertracing:master Nov 17, 2017
@ghost ghost removed the review label Nov 17, 2017
@yurishkuro
Copy link
Member

Thank you @ledor473

@yurishkuro yurishkuro mentioned this pull request Mar 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees

@black-adder black-adder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP compression for static assets
4 participants
@ledor473 @black-adder @coveralls @yurishkuro