-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Use correct argument as jaeger-version #5716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:test
Change that's adding missing tests or correcting existing tests
label
Jul 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5716 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 334 334
Lines 16146 16146
=======================================
Hits 15642 15642
Misses 334 334
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
[bug] Use corret argument as jaeger-version
[bug] Use correct argument as jaeger-version
Jul 7, 2024
dosubot
bot
added
changelog:ci
Change related to continuous integration / testing
storage/elasticsearch
labels
Jul 7, 2024
FlamingSaint
approved these changes
Jul 8, 2024
yurishkuro
removed
the
changelog:test
Change that's adding missing tests or correcting existing tests
label
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
jaeger/scripts/es-integration-test.sh
Lines 102 to 103 in 7b7e5cc
Description of the changes
How was this change tested?