Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run v2 e2e integration tests for Kafka #5782

Merged
merged 8 commits into from
Jul 28, 2024

Conversation

joeyyy09
Copy link
Member

@joeyyy09 joeyyy09 commented Jul 27, 2024

Which problem is this PR solving?

Description of the changes

  • Add v2 e2e integration tests scripts for kafka
  • Add v2 gh workflows for kafka

Checklist

Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
@joeyyy09 joeyyy09 changed the title Add v2 tests for kafka Update v2 e2e integration tests scripts for kafka Jul 27, 2024
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (65f6cb9) to head (c4b54ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5782   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files         342      342           
  Lines       16519    16519           
=======================================
  Hits        15966    15966           
  Misses        363      363           
  Partials      190      190           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 ?
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.03% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.80% <ø> (ø)
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.14% <ø> (+0.01%) ⬆️
kafka ?
kafka-v1 9.74% <ø> (?)
kafka-v2 1.81% <ø> (?)
memory_v2 ?
opensearch-1.x-v1 18.86% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.89% <ø> (ø)
opensearch-2.x-v2 1.81% <ø> (ø)
unittests 95.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scripts/kafka-integration-test.sh Outdated Show resolved Hide resolved
scripts/kafka-integration-test.sh Outdated Show resolved Hide resolved
scripts/kafka-integration-test.sh Outdated Show resolved Hide resolved
scripts/kafka-integration-test.sh Outdated Show resolved Hide resolved
@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Jul 27, 2024
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
@joeyyy09
Copy link
Member Author

the v2 check failed, looking into it.

joeyyy09 and others added 4 commits July 28, 2024 16:38
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Copy link
Member

yurishkuro commented Jul 28, 2024

I pushed the following fix (30ceb02):

  • added flags parsing to the script, to support -K and -j
  • the collector with kafka did not have a query service running on 16686, which caused the test to fail.
    • made a change to cmd/jaeger/internal/integration/e2e_integration.go to allow using a different endpoint for health checking
    • changed collector startup to use "http://localhost:8888/metrics" endpoint instead

With these changes the test is now succeeding

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review July 28, 2024 23:03
@yurishkuro yurishkuro requested a review from a team as a code owner July 28, 2024 23:03
@yurishkuro yurishkuro changed the title Update v2 e2e integration tests scripts for kafka Run v2 e2e integration tests for Kafka Jul 28, 2024
@yurishkuro yurishkuro merged commit a1fe858 into jaegertracing:main Jul 28, 2024
48 checks passed
@joeyyy09
Copy link
Member Author

I pushed the following fix (30ceb02):

* added flags parsing to the script, to support `-K` and `-j`

* the collector with kafka did not have a query service running on 16686, which caused the test to fail.
  
  * made a change to cmd/jaeger/internal/integration/e2e_integration.go to allow using a different endpoint for health checking
  * changed collector startup to use `"http://localhost:8888/metrics"` endpoint instead

With these changes the test is now succeeding

Makes sense, thanks!

@joeyyy09 joeyyy09 deleted the kafka-scripts branch July 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests storage/kafka v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jaeger v2] Add Kafka exporter and receiver
2 participants