Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Use environment variables in Kafka config #6028

Merged
merged 6 commits into from
Sep 29, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Sep 29, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • The change is to an integration test so the CI passing is a good test for this change

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (be48a84) to head (7be814a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6028      +/-   ##
==========================================
+ Coverage   96.90%   96.92%   +0.01%     
==========================================
  Files         349      349              
  Lines       16599    16599              
==========================================
+ Hits        16086    16088       +2     
+ Misses        329      328       -1     
+ Partials      184      183       -1     
Flag Coverage Δ
badger_v1 7.98% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-4.x-v1 15.75% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
cassandra-5.x-v1 15.75% <ø> (ø)
cassandra-5.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.69% <ø> (ø)
elasticsearch-7.x-v1 18.75% <ø> (ø)
elasticsearch-8.x-v1 18.94% <ø> (ø)
elasticsearch-8.x-v2 1.80% <ø> (ø)
grpc_v1 9.51% <ø> (ø)
grpc_v2 7.12% <ø> (ø)
kafka-v1 9.69% <ø> (ø)
kafka-v2 1.81% <ø> (ø)
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.80% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.79% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.80% <ø> (-0.02%) ⬇️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.71% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review September 29, 2024 18:31
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner September 29, 2024 18:31
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Sep 29, 2024
@yurishkuro yurishkuro changed the title [fix][jaeger-v2] Fix Kafka E2E Integration Test To Use Environment Variables [fix][jaeger-v2] Fix Kafka config to use environment variables Sep 29, 2024
@yurishkuro yurishkuro changed the title [fix][jaeger-v2] Fix Kafka config to use environment variables [jaeger-v2] Use environment variables in Kafka config Sep 29, 2024
@yurishkuro yurishkuro merged commit 5598400 into jaegertracing:main Sep 29, 2024
49 of 53 checks passed
@mahadzaryab1 mahadzaryab1 deleted the fix-kafka-e2e branch October 31, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/kafka v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jaeger-v2]: Fix Kafka E2E Test To Use Default Environment Variables
2 participants