Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goleak check #6105

Closed
wants to merge 1 commit into from
Closed

Conversation

inosmeet
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Added goleak check in ./plugin/storage/integration/ directory.

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet inosmeet requested a review from a team as a code owner October 20, 2024 11:10
@inosmeet inosmeet requested a review from albertteoh October 20, 2024 11:10
@dosubot dosubot bot added the area/storage label Oct 20, 2024
@inosmeet
Copy link
Contributor Author

lint-goleak now passes for all packages.
cc @yurishkuro

@inosmeet
Copy link
Contributor Author

These tests are failing due to unexpected goroutines found by Goleak. After looking into it for a while, I’m unsure how to move forward. Can you nudge me in the right direction?? @yurishkuro

@yurishkuro
Copy link
Member

See #5468 (comment)

@yurishkuro
Copy link
Member

closing for now, feel free to re-open once you have the actual fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants