Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize listen host and override when in container #6231

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 20, 2024

Which problem is this PR solving?

Description of the changes

  • Introduce JAEGER_LISTEN_HOST env var used from all-in-one/v2 config
  • Default it to localhost suitable for running directly on host
  • Override it to 0.0.0.0 in the Dockerfile for v2

How was this change tested?

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 20, 2024 18:04
@dosubot dosubot bot added the docker Pull requests that update Docker code label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (8c2340c) to head (388f0ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6231      +/-   ##
==========================================
+ Coverage   96.43%   96.45%   +0.01%     
==========================================
  Files         355      355              
  Lines       20157    20157              
==========================================
+ Hits        19439    19442       +3     
+ Misses        530      528       -2     
+ Partials      188      187       -1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.66% <ø> (-0.01%) ⬇️
grpc_v1 9.43% <ø> (-0.01%) ⬇️
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yurishkuro yurishkuro changed the title Parameterize listen host and vary on host vs. container Parameterize listen host and override when in container Nov 20, 2024
@yurishkuro yurishkuro merged commit 48cf1ba into jaegertracing:main Nov 21, 2024
53 of 54 checks passed
@yurishkuro yurishkuro deleted the param-0.0.0.0 branch November 21, 2024 02:32
@ryetan ryetan mentioned this pull request Nov 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all servers listen on 0.0.0.0
2 participants