Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Rename storage/v1/es to storage/v1/elasticsearch #6655

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 2, 2025

Which problem is this PR solving?

Description of the changes

  • Bring the naming in line with the rest of the backends: es -> elasticsearch
  • Keep direct imports using es as alias to minimize code changes
  • Change es-mapping-generator binary location to match other binaries: ./cmd/esmapping-generator/{binary}-{platform}
  • Remove unused target build-esmapping-generator-linux

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner February 2, 2025 18:48
@yurishkuro yurishkuro requested a review from albertteoh February 2, 2025 18:48
@dosubot dosubot bot added the area/storage label Feb 2, 2025
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Feb 2, 2025
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (f3b3981) to head (a623802).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6655   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files         365      365           
  Lines       20602    20602           
=======================================
  Hits        19765    19765           
  Misses        638      638           
  Partials      199      199           
Flag Coverage Δ
badger_v1 9.92% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 14.93% <ø> (ø)
cassandra-4.x-v2-auto 1.83% <ø> (ø)
cassandra-4.x-v2-manual 1.83% <ø> (ø)
cassandra-5.x-v1-manual 14.93% <ø> (ø)
cassandra-5.x-v2-auto 1.83% <ø> (ø)
cassandra-5.x-v2-manual 1.83% <ø> (ø)
elasticsearch-6.x-v1 19.30% <ø> (ø)
elasticsearch-7.x-v1 19.38% <ø> (ø)
elasticsearch-8.x-v1 19.55% <ø> (ø)
elasticsearch-8.x-v2 1.84% <ø> (ø)
grpc_v1 10.90% <ø> (ø)
grpc_v2 7.89% <ø> (ø)
kafka-3.x-v1 10.21% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.84% <ø> (ø)
opensearch-1.x-v1 19.43% <ø> (ø)
opensearch-2.x-v1 19.43% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro enabled auto-merge (squash) February 2, 2025 19:03
@yurishkuro yurishkuro merged commit d3ceb01 into jaegertracing:main Feb 2, 2025
55 checks passed
@yurishkuro yurishkuro deleted the es-to-elasticsearch branch February 2, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants