Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instant with web-time #214

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Conversation

bernharddick
Copy link
Contributor

Replaces the now deprecated crate instant with web-time

This commit replaces the now deprecated crate instant with web-time
@jaemk jaemk merged commit 6a9d7e5 into jaemk:master Jul 20, 2024
1 check passed
@jaemk
Copy link
Owner

jaemk commented Jul 20, 2024

Thanks! Released 0.53.0

@brandonweeks
Copy link

Was it the intent of this change to pull in the wasm-bindgen collection of crates even when the wasm feature is not selected?

@jaemk
Copy link
Owner

jaemk commented Jul 23, 2024

The wasm feature actually isn't necessary anymore and could be removed. web_time only uses/exposes wasm functionality when compiling for the wasm target: https://docs.rs/web-time/latest/web_time/

At the same time the library will simply re-export std::time when not using the wasm32-unknown-unknown target and will not pull in any dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants