Fixed Signature for this request is not valid on POST requests

jaggedsoft · Aug 28, 2019 · cad1b71 · cad1b71
1 parent 1d22afb
commit cad1b71
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/php-binance-api.php b/php-binance-api.php
@@ -1,5 +1,4 @@
 <?php
-
 /*
  * ============================================================
  * @package php-binance-api
@@ -893,7 +892,9 @@ private function httpRequest(string $url, string $method = "GET", array $params
             $query = http_build_query($params, '', '&');
             $signature = hash_hmac('sha256', $query, $this->api_secret);
             if ($method === "POST") {
-                $endpoint = $base . $url . '?' . 'signature=' . $signature;
+                $endpoint = $base . $url;
+				$params['signature'] = $signature; // signature needs to be inside BODY
+				$query = http_build_query($params, '', '&'); // rebuilding query
             } else {
                 $endpoint = $base . $url . '?' . $query . '&signature=' . $signature;
             }