Switch to Community Maintained fork of bump-lavaplayer #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried setting this up as an alternative to using red-discordbot and ended up immediately running into jagrosh#885. There is also jagrosh#1375 which advocates for moving to youtube-dl+ffmpeg as a replacement for lavaplayer, but that would take quite a bit of work as it is called out in the issue. After the OG lavaplayer repo was abandoned, the community forked it and has been maintaining it since: https://github.com/lavalink-devs/lavaplayer This commit moves us from using this project's forked version to the community's fork. I tested this with some tracks that were returning HTTP 403s and it is now resolved (at least in my testing...)
|
Hi, thank you for this PR! I've seen & been pointed out to several lavaplayer forks, though I haven't spent much time looking into any of them. Would you happen to be familiar with the situation of lavaplayer forks & can elaborate on it? If not, that's perfectly fine. |
|
Hi! I've been using the same library for a few weeks on my bot, and there's literally no way out of any 403 error (I've checked the issues relating to this kind of problem, and all the videos mentioned go through without a hitch). You're free to go, it works more than fine. Thank you very much for the work you do to maintain this bot! |
|
Superseded by #1490 |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
I tried setting this up as an alternative to using red-discordbot and ended up immediately running into #885.
There is also #1375 which advocates for moving to youtube-dl+ffmpeg as a replacement for lavaplayer, but that would take quite a bit of work as it is called out in the issue.
After the OG lavaplayer repo was abandoned, the community forked it and has been maintaining it since:
https://github.com/lavalink-devs/lavaplayer
This commit moves us from using this project's forked version to the community's fork.
I tested this with some tracks that were returning HTTP 403s and it is now resolved (at least in my testing...)
Purpose
Bumping this to a more recent version allows us to pull in a fix from lavalink-devs/lavaplayer/pull/16
Relevant Issue(s)
This PR closes issue #885