Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shell comparsion in run script #1627

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

TimothyGillespie
Copy link
Contributor

@TimothyGillespie TimothyGillespie commented Jul 25, 2024

This pull request...

  • Fixes a bug
  • Introduces a new feature
  • Improves an existing feature
  • Boosts code quality or performance

Description

This pull requests ensure that the script will actually work with a POSIX-compliant shell such as sh.

Purpose

This script does not work on a Linux system in sh since == seems to be an extra feature in bash.

One could set the shebang line to /bin/bash as well, but staying within shell should be more universal.

Relevant Issue(s)

None that I know off.

@jagrosh jagrosh merged commit f140b41 into jagrosh:master Aug 1, 2024
2 checks passed
uncreativeCultist added a commit to uncreativeCultist/MusicBotShiverFork that referenced this pull request Aug 10, 2024
ElerWohlmuthFH pushed a commit to ElerWohlmuthFH/MusicBot that referenced this pull request Sep 20, 2024
MichailiK pushed a commit to MichailiK/MusicBot that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants