Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component-generate-cli): implements new component scafollding with CLI #66

Merged
merged 8 commits into from
Nov 7, 2024
Merged

feat(component-generate-cli): implements new component scafollding with CLI #66

merged 8 commits into from
Nov 7, 2024

Conversation

mrtag23
Copy link
Collaborator

@mrtag23 mrtag23 commented Oct 31, 2024

No description provided.

@mrtag23 mrtag23 requested a review from asgorobets October 31, 2024 18:13
@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-contentful ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 9:21pm

@asgorobets asgorobets force-pushed the feat/component-generate-cli branch from 728585a to 111991f Compare October 31, 2024 19:19
@asgorobets
Copy link
Collaborator

@mrtag23 Looks like Node 20 is not what's causing those builds to fail, at least not node 20 alone. I have upgraded to Node 20 in main now (merged), so feel free to start with main as base and roll your changes to see when builds start to fail

@asgorobets
Copy link
Collaborator

@mrtag23 Additionally, you can check vercel-test branch as my test of just the package.json and yarn.lock updates, it builds successfully on Vercel. It looks like your yarn.lock has waaaay too many upgrades to other components, which we should avoid in this PR. I suggest you roll your changes over the clean branch, or steal my yarn.lock if you wish

This was referenced Nov 3, 2024
Closed
Merged
@mrtag23 mrtag23 force-pushed the feat/component-generate-cli branch from 36095e7 to 4c65837 Compare November 4, 2024 15:10
@mrtag23 mrtag23 linked an issue Nov 4, 2024 that may be closed by this pull request
CLI for generating new component stubs #59
Closed
asgorobets
asgorobets approved these changes Nov 7, 2024
View reviewed changes
inquirer/generate-component.mjs Outdated
@@ -0,0 +1,38 @@
import chalk from 'chalk';
import inquirer from 'inquirer';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to inquirer docs, @inquirer/prompts is the new library that will receive support and development, and legacy inquirer will just be in maintenance mode.

I'd switch it up to the new one so we don't start with legacy dependencies
I've also found https://www.npmjs.com/package/prompts to be quite popular, shadcn/ui CLI uses prompts.

@asgorobets asgorobets merged commit 5d43607 into main Nov 7, 2024
4 checks passed
@asgorobets asgorobets deleted the feat/component-generate-cli branch November 7, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgorobets asgorobets asgorobets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI for generating new component stubs
2 participants
@mrtag23 @asgorobets