Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative tests for build compatible extensions with invalid metho… #329

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Dec 8, 2021

…d parameter combinations.

Fixes #321

Adds ten tests for various invalid combinations of parameters in @Enhancement and @Registration phases.

@Ladicek all tests are expecting a DefinitionException - I originally wanted to do deployment exception (as we said in spec, see jakartaee/cdi@7b085ac) but I ended up thinking it's really a definition issue. I can change the spec wording accordingly if we agree on it.

@manovotn manovotn merged commit db7cd70 into jakartaee:master Dec 8, 2021
@manovotn manovotn deleted the issue321 branch December 8, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create negative tests for build compatible extensions
2 participants