Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AnnotationLiteral lazy #514

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Make AnnotationLiteral lazy #514

merged 1 commit into from
Aug 10, 2021

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Aug 9, 2021

AnnotationLiteral eagerly initializes the reflective state of annotations. This state may not be needed if the implementation does not use reflection to access annotation literal members. This change makes this intialization lazy to avoid always initializing this state.

@graemerocher graemerocher requested a review from Ladicek August 9, 2021 14:59
@Ladicek Ladicek requested a review from manovotn August 9, 2021 15:13
@Ladicek
Copy link
Contributor

Ladicek commented Aug 9, 2021

Looks good, WDYT @manovotn?

Copy link
Contributor

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ladicek Ladicek merged commit c43240d into master Aug 10, 2021
@Ladicek Ladicek deleted the annotation-literal-lazy branch August 10, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants