Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API changes for allowing @Priority on stereotypes #527

Merged
merged 1 commit into from
Sep 20, 2021
Merged

API changes for allowing @Priority on stereotypes #527

merged 1 commit into from
Sep 20, 2021

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Sep 14, 2021

No description provided.

@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 14, 2021

This is a follow-up on #524. I realized we should probably do this sooner rather than later.

@Ladicek Ladicek force-pushed the stereotype-priority branch from be70679 to deffaf9 Compare September 14, 2021 13:46
manovotn
manovotn reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't realize I should change it here as well.

api/src/main/java/jakarta/enterprise/inject/build/compatible/spi/StereotypeInfo.java Outdated Show resolved Hide resolved
@Ladicek Ladicek force-pushed the stereotype-priority branch from deffaf9 to b256ceb Compare September 20, 2021 12:26
@Ladicek Ladicek force-pushed the stereotype-priority branch from b256ceb to 795d5c1 Compare September 20, 2021 12:30
@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 20, 2021

I have another set of changes that allow directly representing interceptors (InterceptorInfo extends BeanInfo). I will submit them in another PR.

@Ladicek Ladicek merged commit 3c3d15c into jakartaee:master Sep 20, 2021
@Ladicek Ladicek deleted the stereotype-priority branch September 20, 2021 13:27
@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 20, 2021

Thanks!

@Ladicek Ladicek mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emily-Jiang Emily-Jiang Emily-Jiang left review comments

@manovotn manovotn manovotn approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ladicek @graemerocher @manovotn @Emily-Jiang