Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programmatic lookup improvements, introduce Handle interface. #534

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Programmatic lookup improvements, introduce Handle interface. #534

merged 1 commit into from
Oct 6, 2021

Conversation

manovotn
Copy link
Contributor

Resolves #521

BTW, I will also prepare a draft of a TCK test based on what we had in Weld.

@manovotn manovotn requested a review from Ladicek September 27, 2021 07:26
@manovotn
Copy link
Contributor Author

@Ladicek @mkouba I didn't include the getPriorityComparator() method in this PR. If you think it should be included, do let me know please :)

@manovotn manovotn marked this pull request as draft September 27, 2021 07:40
@manovotn manovotn force-pushed the handlerApi branch 2 times, most recently from ac89491 to 786b223 Compare September 27, 2021 08:10
@manovotn manovotn marked this pull request as ready for review September 27, 2021 08:13
@Ladicek
Copy link
Contributor

Ladicek commented Sep 27, 2021

I would stay away from the priority comparator, if only because of the 0 value :-)

@manovotn manovotn requested a review from Ladicek September 27, 2021 13:55
@manovotn
Copy link
Contributor Author

manovotn commented Oct 6, 2021

@Ladicek could you please green-stamp this? Unless there is something else you want me to change of course.

@Ladicek
Copy link
Contributor

Ladicek commented Oct 6, 2021

Done. Sorry, totally forgot about this!

Ladicek
Ladicek requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I know that I wanted something changed :-) The Handle.getBean() method return type.

@manovotn
Copy link
Contributor Author

manovotn commented Oct 6, 2021

Actually I know that I wanted something changed :-) The Handle.getBean() method return type.

Ah, right, good point!
Fixed that, the method now looks like this - Bean<T> getBean();

@manovotn manovotn requested a review from Ladicek October 6, 2021 13:05
@Ladicek
Copy link
Contributor

Ladicek commented Oct 6, 2021

Thanks!

@manovotn manovotn merged commit f0fd7f7 into jakartaee:master Oct 6, 2021
@manovotn manovotn deleted the handlerApi branch October 6, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Programmatic lookup improvements
2 participants
@manovotn @Ladicek