-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update asciidoc plugins, config #559
Conversation
Update the root readme Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
I looked into updating Asciidoctor when prototyping specref and I did it like this.
...
<properties>
<asciidoctor-maven.version>2.2.1</asciidoctor-maven.version>
<asciidoctorj.version>2.5.2</asciidoctorj.version> <!-- <<<<< added line <<<<< -->
<asciidoctorj-pdf.version>1.6.0</asciidoctorj-pdf.version>
...
</properties>
...
...
<plugin>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctor-maven-plugin</artifactId>
<version>${asciidoctor-maven.version}</version>
<dependencies>
<!-- >>>>> added dependency >>>>> -->
<dependency>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctorj</artifactId>
<version>${asciidoctorj.version}</version>
</dependency>
<!-- <<<<< added dependency <<<<< -->
<dependency>
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctorj-pdf</artifactId>
<version>${asciidoctorj-pdf.version}</version>
</dependency>
</dependencies>
...
</plugin>
<configuration>
<sourceDirectory>src/main/asciidoc</sourceDirectory> <!-- otherwise warnings are printed -->
<sourceDocumentName>cdi-spec.asciidoc</sourceDocumentName>
<attributes>
<license>${license-file}</license>
<revremark>${revremark}</revremark>
<imagesdir>images</imagesdir>
<source-highlighter>coderay</source-highlighter>
</attributes>
</configuration> |
…ory and imagesdir Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
I have updated the plugin configuration to use the explicit asciidoctorj.version setting and added the addition configuration/attribute changes. The test build with this PR shows no errors/warnings: |
I vaguely recall seeing a |
Addresses #558