-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand "What's New" section #125
Conversation
…erences. Signed-off-by: David Blevins <david.blevins@gmail.com>
@hussainnm Would love your feedback on this one too. (thanks again for all your contributions) |
* _Removed the deprecated EJBContext.getEnvironment() method._ | ||
|
||
* _Removed the Support for Distributed Interoperability to reflect | ||
the removal of CORBA from Java 11 and the Jakarta EE 9 Platform._ | ||
|
||
* _Marked the EJB 2.x API Group as "Optional"_ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current spec document, the term "Enterprise Beans 2.x API" is used. I think we should use the new term name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that isn't a change part of this PR. That said, the trademark rules here are a little nuanced. Here's the discussions we've had in the Specification/Steering committees and the guidance we've been given on use of either trademark.
- When referring to the specification in general or referring to a new version of the specification, we should use the new name.
- When explicitly referring to past JCP versions of the specification we should take care to use the appropriate trademark. For example, "J2EE 1.2" not "Jakarta EE 1.2"
Similarly, when "Java EE" became the new name for "J2EE" we continued to refer to the older specs using their proper name "J2EE 1.3", "J2EE 1.4", etc and did not being referring to them as "Java EE 1.3", "Java EE 1.4", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to change EJB 2.x to Enterprise Beans 2.x.
As I have explained in the mailing list, an earlier version under the new namespace should be referred with the new name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to change EJB 2.x to Enterprise Beans 2.x.
This does not appear to be a reference to an older spec level, but instead is a reference to a subset of the current specification, specifically the 2.x API Group, so should use the same terminology as in the rest of the current version of the spec.
|
||
* _Removed the methods relying on java.security.Identity_ | ||
* _All 'javax.ejb' namespace/packages have been renamed to 'jakarta.ejb'_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal preference of formatting, either javax.ejb
jakarta.ejb
, or the plain javax.ejb jakarta.ejb. The single quote seems a bit odd here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed.
Signed-off-by: David Blevins <david.blevins@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* _Removed the deprecated EJBContext.getEnvironment() method._ | ||
|
||
* _Removed the Support for Distributed Interoperability to reflect | ||
the removal of CORBA from Java 11 and the Jakarta EE 9 Platform._ | ||
|
||
* _Marked the EJB 2.x API Group as "Optional"_ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to change EJB 2.x to Enterprise Beans 2.x.
This does not appear to be a reference to an older spec level, but instead is a reference to a subset of the current specification, specifically the 2.x API Group, so should use the same terminology as in the rest of the current version of the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dblevins I have reviewed and approved.
Note that there was a conflict with your previous PR I merged this morning. So I resolved it. Hopefully it's good.
The spirit of this update is to: