Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#78 refresh intro and preface #84

Merged
merged 16 commits into from
Dec 2, 2023

Conversation

kito99
Copy link

@kito99 kito99 commented Nov 21, 2023

Updated preface and rewrote most of the intro. I'd love feedback on the following:

I'd prefer comments directly in the PR; if you want to see what it looks like deployed, I updated the main build to use this branch for Jakarta EE 10, so you can see it here: https://jakartaee.github.io/jakartaee-documentation/jakartaee-tutorial/current/. This way you can easily switch back to the old version by changing to 9.1 in the upper right-hand corner.

Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace CDI managed bean components with CDI managed beans. Otherwise LGTM

@kito99
Copy link
Author

kito99 commented Nov 21, 2023

Technically, the preface should be in the index above the intro as it is for 9.1.

@kito99
Copy link
Author

kito99 commented Nov 22, 2023

The colors of the last two images don't match.

@kito99
Copy link
Author

kito99 commented Nov 22, 2023

Proofread once more.

@kito99
Copy link
Author

kito99 commented Nov 22, 2023

Change "Jakarta EE Services" heading to "Jakarta EE Services and Profiles" and mention that which profiles you can access depends on the server, and refer to another section (how do I get it?).

@kito99
Copy link
Author

kito99 commented Nov 22, 2023

Add table and figure captions, and link to them as we do elsewhere in the tutorial.

@kito99
Copy link
Author

kito99 commented Dec 2, 2023

Created separate tickets for the tasks above.

@kito99 kito99 merged commit 6429528 into main Dec 2, 2023
1 check passed
@kito99 kito99 deleted the feature/#78_refresh_intro_and_preface branch December 2, 2023 20:35
@kito99 kito99 mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants