-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#78 refresh intro and preface #84
Conversation
…o the style guide.
…ropriate location.
…re no longer used.
src/main/antora/modules/intro/pages/overview/overview-jakartaee-components.adoc
Outdated
Show resolved
Hide resolved
src/main/antora/modules/intro/pages/overview/overview-highlights.adoc
Outdated
Show resolved
Hide resolved
src/main/antora/modules/intro/pages/overview/overview-jakartaee-services.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace CDI managed bean components with CDI managed beans. Otherwise LGTM
src/main/antora/modules/intro/pages/overview/overview-jakartaee-components.adoc
Outdated
Show resolved
Hide resolved
src/main/antora/modules/intro/pages/overview/overview-what-is-jakarta-ee.adoc
Outdated
Show resolved
Hide resolved
Technically, the preface should be in the index above the intro as it is for 9.1. |
The colors of the last two images don't match. |
Proofread once more. |
Change "Jakarta EE Services" heading to "Jakarta EE Services and Profiles" and mention that which profiles you can access depends on the server, and refer to another section (how do I get it?). |
Add table and figure captions, and link to them as we do elsewhere in the tutorial. |
Created separate tickets for the tasks above. |
Updated preface and rewrote most of the intro. I'd love feedback on the following:
I'd prefer comments directly in the PR; if you want to see what it looks like deployed, I updated the main build to use this branch for Jakarta EE 10, so you can see it here: https://jakartaee.github.io/jakartaee-documentation/jakartaee-tutorial/current/. This way you can easily switch back to the old version by changing to 9.1 in the upper right-hand corner.