Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Dependabot v2 #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jun 20, 2020

@sullis sullis changed the title add Dependabot add Dependabot v2 Aug 24, 2020
@sullis sullis changed the title add Dependabot v2 enable Dependabot v2 Aug 24, 2020
@sullis
Copy link
Contributor Author

sullis commented Aug 24, 2020

@lukasj WDYT?

@lukasj
Copy link
Contributor

lukasj commented Aug 24, 2020

not a blocker for the current release, can wait for the next one

schedule:
interval: "daily"
time: "02:00"
- package-ecosystem: "github-actions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions are not enabled here and no action is executed, so why have this ecosystem covered at all?

Copy link
Contributor

@lukasj lukasj Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did someone say that actions can never be enabled here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you accept gradle ecosystem as well, as noone said it can never be migrated to gradle then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling actions is about filing a bug to the repo owners should it bring in some benefits - how much time that needs? 10 minutes? Have anyone had cycles to investigate benefits it can bring as well as its disadvantages? Compare that with effort needed to convert this project, and thus all ee4j projects, to gradle. Discussion wrt gradle was on the table in the past but who and when would do that work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used gradle only as example of other not needed now dependabot ecosystem.

Copy link
Contributor

@lukasj lukasj Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-update of dependencies is good thing to have, some projects are using jenkins for it. These projects may go away from that solution at some point and move to what's suggested here too. It is just not the right time to make decision and merge/work on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants