Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong version 53 package-info #389

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Wrong version 53 package-info #389

merged 1 commit into from
Apr 19, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Nov 24, 2022 •
edited
Loading

Original issue is here: eclipse-ee4j/parsson#73
PR for Parsson is: eclipse-ee4j/parsson#74

Fix can be verified in this way:

jsonp/api$ javap -verbose -classpath target/jakarta.json-api-2.1.1-SNAPSHOT.jar jakarta.json.package-info | grep version
  minor version: 0
  major version: 52

@jbescos
Wrong version 53 package-info
8d10c8a 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
lukasj
lukasj approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 713fc69 into jakartaee:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbescos @lukasj