Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed workaround to the jakarta.mail.util.StreamProvider #702

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions api/src/main/java/jakarta/mail/util/FactoryFinder.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,23 @@ private static <T> T newInstance(String className) throws RuntimeException {
ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
checkPackageAccess(className);
Class<T> clazz = null;
T t = null;
try {
if (classLoader == null) {
clazz = (Class<T>) Class.forName(className);
} else {
if (classLoader != null) {
clazz = (Class<T>) classLoader.loadClass(className);
}
return clazz.getConstructor().newInstance();
t = clazz.getConstructor().newInstance();
} catch (ReflectiveOperationException e) {
throw new IllegalArgumentException("Cannot instance " + className, e);
//Going for second option
}
if(t == null) {
try {
t = (T)Class.forName(className).getConstructor().newInstance();
} catch ( ReflectiveOperationException e) {
throw new IllegalArgumentException("Cannot instance " + className, e);
}
}
return t;
}

private static String fromSystemProperty(String factoryId) {
Expand Down