Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating standalone Pages TCK from platform TCK project #261

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

alwin-joseph
Copy link
Contributor

Migration of Pages standalone TCK sources from Platform TCK project

To generate the userguide :

mvn -f tck/docs/userguide

To generate EFTL TCK bundle:

mvn -f tck clean install

To generate EPL TCK bundle:

mvn -f tck clean install -PEPL

Pending/outstanding items:

@markt-asf
Copy link
Contributor

Is the intention that this is merged before or after the JSP 4.0 release?

@alwin-joseph
Copy link
Contributor Author

alwin-joseph commented Mar 26, 2024

Is the intention that this is merged before or after the JSP 4.0 release?

Before. IMHO there isn't any reason the pages standalone TCK sources cannot be moved to this project now for 4.0 release.

@markt-asf
Copy link
Contributor

OK. We are VERY tight for time but I'll try and do this.

@markt-asf
Copy link
Contributor

I'm going to merge this shortly but I suggest keeping the files in the TCK project until is confirmed that the TCK can be built correctly from the new location.

@markt-asf markt-asf merged commit a511634 into jakartaee:master Mar 27, 2024
1 check passed
@alwin-joseph
Copy link
Contributor Author

I'm going to merge this shortly but I suggest keeping the files in the TCK project until is confirmed that the TCK can be built correctly from the new location.

I created issue https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4480 to create new folder /home/data/httpd/download.eclipse.org/ee4j/pages.

@alwin-joseph
Copy link
Contributor Author

alwin-joseph commented Mar 28, 2024

I'm going to merge this shortly but I suggest keeping the files in the TCK project until is confirmed that the TCK can be built correctly from the new location.

I created issue https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4480 to create new folder /home/data/httpd/download.eclipse.org/ee4j/pages.

This issue is resolved and folder https://download.eclipse.org/ee4j/pages/ is created.

@alwin-joseph
Copy link
Contributor Author

alwin-joseph commented Mar 29, 2024

Pages TCK build is dependent on common modules and lib/javatest.jar from https://github.com/jakartaee/platform-tck/tree/tckrefactor branch

Below steps can be used to build the standalone TCK in a Jenkins Job:

In Jenkins Job , can use below to create a subfolder(tck/eftl) in https://download.eclipse.org/ee4j/pages :

  • ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null genie.jsp@projects-storage.eclipse.org mkdir -p /home/data/httpd/download.eclipse.org/ee4j/pages/tck/eftl

In Jenkins Job , can use below to copy the bundle to Eclipse folder:

  • scp $tck_bundle genie.jsp@projects-storage.eclipse.org:/home/data/httpd/download.eclipse.org/ee4j/pages/tck/eftl/
    #tck_bundle will be the bundle name built at cd $WORKSPACE/pages/tck/target/*.zip

The current Jenkins Job in platform-tck project is https://ci.eclipse.org/jakartaee-tck/job/11/job/standalone-tck/job/eftl-pages-standalonetck-build/configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants