Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default EE10 porting.ts.url.class.1 value is no longer valid in EE11 #1439

Closed
starksm64 opened this issue Aug 7, 2024 · 0 comments · Fixed by #1964
Closed

The default EE10 porting.ts.url.class.1 value is no longer valid in EE11 #1439

starksm64 opened this issue Aug 7, 2024 · 0 comments · Fixed by #1964
Assignees
@starksm64
Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release

Comments

@starksm64
Copy link
Contributor

starksm64 commented Aug 7, 2024 •
edited
Loading

Some of the web invocation based tests make use of a com.sun.ts.lib.porting.TSURL class that looks for a test property called porting.ts.url.class.1 to load the class which implements TSURLInterface. The default EE10 value in the ts.jte file is com.sun.ts.lib.implementation.sun.common.SunRIURL, but this does not existing in the EE11 codebase. Its replacement is com.sun.ts.lib.porting.implementation.SunRIURL found in the runtime module.

There are duplicate implementations of this class in these test module packages:
com.sun.ts.tests.jaxrs.lib.implementation.sun.common
com.sun.ts.tests.jstl.lib.implementation.sun.common
com.sun.ts.tests.websocket.lib.implementation.sun.common
ee.jakarta.tck.pages.lib.implementation.sun.common

Need to document how this is handled in EE11 and whether the duplicates are needed.
@starksm64 starksm64 converted this from a draft issue Aug 7, 2024
@starksm64 starksm64 self-assigned this Aug 7, 2024
@starksm64 starksm64 moved this to In progress in Jakarta EE11 TCK Release Aug 7, 2024
@gurunrao gurunrao added the 11.0 Issues related to the Jakarta EE 11 Platform TCK release label Oct 4, 2024
starksm64 added a commit that referenced this issue Feb 20, 2025
@starksm64
Update the default value of the porting.ts.url.class.1 property and i…
f7afb95 
…mprove the documentation for these properties.

Fixes #1439

Signed-off-by: Scott M Stark <starksm@starkinternational.com>
@starksm64 starksm64 mentioned this issue Feb 20, 2025
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Jakarta EE11 TCK Release Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starksm64 starksm64

Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release
Projects
Jakarta EE11 TCK Release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the default value of the porting.ts.url.class.1 property and i… jakartaee/platform-tck
2 participants
@starksm64 @gurunrao