Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support JDK21 and security manager disabled. #1163

Closed
wants to merge 1 commit into from

Conversation

gurunrao
Copy link
Contributor

@gurunrao gurunrao commented Apr 12, 2023

PR supports Platform TCK and Standalone TCK[ Annotations, EL, JAXWS, JMS, JPA, JSP, JSTL, JTA,SAAJ, SERVLET and WEBSOCKET] built with JDK 21- build 15.
Also TCK runs with JDK 21(build 15) and Security manager disabled.
The javatest jar has been built from latest source at https://github.com/openjdk/jtharness.git

Standalone TCK CI run: https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakartaee-tck-build-run/job/security-manager/12/#showFailuresLink
Platform TCK CI run: https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakartaee-tck-build-run/job/security-manager/14/

Signed-off-by: gurunrao <gurunandan.rao@oracle.com>
@scottmarlow
Copy link
Contributor

FYi, this can be considered as in support of jakartaee/platform#551 however, I think we need a Platform update on how much of the Java Security Manager will be in JDK21.

Also should this change be directed at the tckrefactor branch?

@gurunrao
Copy link
Contributor Author

gurunrao commented Apr 20, 2023

FYi, this can be considered as in support of jakartaee/jakartaee-platform#551 however, I think we need a Platform update on how much of the Java Security Manager will be in JDK21.

We can do further enhancements based on Platform update on Security Manager.

Also should this change be directed at the tckrefactor branch?

Javatest will be eliminated due to refactor of platform TCK with Junit and arquillian, Hence we need not direct the change to tckrefactor branch.

@scottmarlow
Copy link
Contributor

Another option is to merge this pr (when ready) into a securitymanager branch.

@scottmarlow
Copy link
Contributor

Or keep https://github.com/gurunrao/jakartaee-tck/tree/security-manager around until we are ready to merge this change to master branch.

@gurunrao gurunrao marked this pull request as ready for review April 24, 2023 01:18
@@ -1146,8 +1146,9 @@ command.testExecute=com.sun.ts.lib.harness.ExecTSTestCmd \
-Dprovider.configuration.file=${provider.configuration.file} \
-Djava.security.properties=${s1as.domain}/${sjsas.instance.config.dir}/ts.java.security \
-Dlogical.hostname.servlet=${logical.hostname.servlet} \
-DnoSecurityManager=true \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added below as well.

@gurunrao gurunrao closed this Mar 12, 2024
@gurunrao
Copy link
Contributor Author

PR #1219 has same changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants