User guide for SAAJ updated. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
scottmarlow
reviewed
Jul 29, 2020
scottmarlow
reviewed
Jul 29, 2020
edbratt
requested changes
Jul 30, 2020
There was a problem hiding this comment.
Thank you -- please consider the following:
- attributes.conf: Update the following properties: {TechnologyRI} to EclipseGlassFish 6.0; {TechnologyRIURL} to https://projects.eclipse.org/projects/ee4j.glassfish; {SpecificationInquiryList} to jaxws-dev@eclipse.org; {TCKPackageName} to jakarta-soap-tck-2.0.0.zip
- req-software.inc - Change first example, "Java EE 8 RI" to "Eclipse GlassFish 6.0 Compatible Implementation"
- install-server.inc - please update with current terminology (Java EE 8 RI -> Jakarta EE 9 Compatible Platform (some examples: Eclipse GlassFish 6); change RI to Compatible Implementation; Change software can be obtained from, to point to the Jakarta EE 9 Platform Specification page, or suggest the user can obtain a compatible implementation from Eclipse GlassFish 6).
- debug-tips.inc - please delete the code header at the top of this file. Otherwise, this header is rendered in Chapt. 6, Debugging Test Problems (debug.adoc).
- rebuild.inc - Please review this file and update language, component and package names (RI to Compatible Implementation, Etc.). This is rendered in Appendix B (rebuild.adoc).
- install/saaj/docs/SAAJ2.0-ReleaseNotes.html: please update the release date in the page title.
|
Did local build. Bundle name is
|
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
scottmarlow
approved these changes
Jul 31, 2020
|
The final build target names were established by the Specification Committee. You can use this folder to find the final names of all TCKs generated by the release process by this project. I guess Local builds produce different file names. I wasn't aware of that. |
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
|
Thanks for the info. Name should be OK now. |
edbratt
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
I will approve but there's one final thing I may have not pointed out previously: In faq.adoc, line 58 you could change: "reference implementation" to "Compatible Implementation".
Also in attributes.conf, if you could add a space between Eclipse and GlassFish, on link 5 (the definition of TechnologyRI, that would be cool also.
| @@ -2,8 +2,8 @@ | |||
| :TechnologyShortName: SOAP Attachments | |||
| :LegacyAcronym: SAAJ | |||
| :TechnologyVersion: 2.0 | |||
| :TechnologyRI: GlassFish 6.0 | |||
| :TechnologyRIURL: https://eclipse-ee4j.github.io/glassfish/ | |||
| :TechnologyRI: EclipseGlassFish 6.0 | |||
There was a problem hiding this comment.
Nit: add space: Eclipse GlassFish 6.0
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
|
I just need someone to merge it. I'm not a commiter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the guide: SAAJ-TCK-Users-Guide.pdf